[lkml]   [2022]   [Dec]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH AUTOSEL 5.10 5/9] proc/vmcore: fix potential memory leak in vmcore_init()
From: Jianglei Nie <>

[ Upstream commit 12b9d301ff73122aebd78548fa4c04ca69ed78fe ]

Patch series "Some minor cleanup patches resent".

The first three patches trivial clean up patches.

And for the patch "kexec: replace crash_mem_range with range", I got a
ibm-p9wr ppc64le system to test, it works well.

This patch (of 4):

elfcorehdr_alloc() allocates a memory chunk for elfcorehdr_addr with
kzalloc(). If is_vmcore_usable() returns false, elfcorehdr_addr is a
predefined value. If parse_crash_elf_headers() gets some error and
returns a negetive value, the elfcorehdr_addr should be released with

Fix it by calling elfcorehdr_free() when parse_crash_elf_headers() fails.

Signed-off-by: Jianglei Nie <>
Signed-off-by: Baoquan He <>
Acked-by: Baoquan He <>
Cc: Benjamin Herrenschmidt <>
Cc: Chen Lifu <>
Cc: "Eric W . Biederman" <>
Cc: Li Chen <>
Cc: Michael Ellerman <>
Cc: Paul Mackerras <>
Cc: Petr Mladek <>
Cc: Russell King <>
Cc: ye xingchen <>
Cc: Zeal Robot <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Sasha Levin <>
fs/proc/vmcore.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c
index 0e4278d4a769..484fa0c029e1 100644
--- a/fs/proc/vmcore.c
+++ b/fs/proc/vmcore.c
@@ -1553,6 +1553,7 @@ static int __init vmcore_init(void)
return rc;
rc = parse_crash_elf_headers();
if (rc) {
+ elfcorehdr_free(elfcorehdr_addr);
pr_warn("Kdump: vmcore not initialized\n");
return rc;
 \ /
  Last update: 2022-12-17 16:39    [W:0.052 / U:0.660 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site