[lkml]   [2022]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH net-next v2] net: ipa: Remove redundant dev_err()
Thank you for your precious feedback.

> The current version of net-next/master, as well as the
> current linus/master, do not include the message you
> are removing. This patch removed the message more than
> a year ago:
> 91306d1d131ee net: ipa: Remove useless error message
> So at least the portion of your patch that removes the
> message is unnecessary.

Yes, I think I mistakenly worked on the wrong branch..

> Meanwhile, it seems there is no need to check for a 0
> return from platform_get_irq_byname(), but there is
> no harm in doing so.
> If you would like to send version 3 of this patch, which
> would return what platform_get_irq_byname() returns if it
> is less than 0 in gsi_irq_init(), I would be OK with that.
> But please it on net-next/master.

Ok, I'll send v3 of this patch soon.

 \ /
  Last update: 2022-12-16 21:00    [W:0.059 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site