Messages in this thread |  | | Date | Fri, 16 Dec 2022 11:18:21 -0600 | From | Segher Boessenkool <> | Subject | Re: [PATCH v2] powerpc: Pass correct CPU reference to assembler |
| |
Hi!
On Fri, Dec 16, 2022 at 09:35:50AM +0100, Christophe Leroy wrote: > The problem comes from the fact that CONFIG_PPC_E500MC is selected for > both the e500mc (32 bits) and the e5500 (64 bits), and therefore the > following makefile rule is wrong: > > cpu-as-$(CONFIG_PPC_E500MC) += $(call as-option,-Wa$(comma)-me500mc)
Yes.
> Today we have CONFIG_TARGET_CPU which provides the identification of the > expected CPU, it is used for GCC. Use it as well for the assembler.
Why do you use -Wa, at all for this? The compiler should already pass proper options always!
> +cpu-as-$(CONFIG_PPC_BOOK3S_64) += $(call as-option,-Wa$(comma)-many)
What is this for? Using -many is a huge step back, it hides many problems :-(
Segher
|  |