lkml.org 
[lkml]   [2022]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH] arm64: dts: qcom: Use labels with generic node names for ADC channels
On 2022-12-16 11:49:09, Krzysztof Kozlowski wrote:
> [..]
> > My commit message explains why the ADC5/VADC driver should really
> > receive a label property instead of using the node name.
>
> The reason "unpleasant file-browsing experience" is usually OS specific,
> so it does not justify requiring a label property. Label is just a
> helper for the users.

Ack. Then it's up to the driver to figure out what's best here. My
suggestion on top of the proposed handling by Jonathan:

a) Use label if present.
b) Use node name if it's not adc-chan but strip the @xxx off it.
c) Use (currently unused) hardcoded name in the driver.

Unfortunately we have two drivers (VADC and ADC5) to deal with, where the
VADC driver is not affected by any of these filename problems, nor won't
be. It doesn't have a label in Linux at all yet so there's no userspace
ABI to (un)break, only DT ABI.

- Marijn

\
 
 \ /
  Last update: 2022-12-16 12:05    [W:0.041 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site