lkml.org 
[lkml]   [2022]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for quad-uart support
Date
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Friday, December 16, 2022 3:09 PM
> To: Tharunkumar Pasumarthi - I67821
> <Tharunkumar.Pasumarthi@microchip.com>
> Subject: Re: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
> quad-uart support
>
> > From this sequence, it seemed like, kernel takes care of freeing irq
> > and calling pci_free_irq_vectors is not required.
>
> Technically you are correct, but... read this discussion, and pay attention to
> what Christoph said there:
>
> https://lore.kernel.org/linux-serial/0250c46e-da6c-71f3-50ae-
> b7c17fd0bd2c@siemens.com/

Okay, got it. Will use pci_free_irq_vectors.
Also, do you suggest using pci_enable_device instead of pcim_enable_device (to maintain consistency
of using non managed APIs throughout driver)?

Thanks,
Tharun Kumar P

\
 
 \ /
  Last update: 2022-12-16 11:32    [W:13.618 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site