lkml.org 
[lkml]   [2022]   [Dec]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] scsi: libsas: Directly kick-off EH when ATA device fell off
From


On 2022/12/16 17:29, Jason Yan wrote:
> On 2022/12/16 11:29, Xingui Yang wrote:
>> If the ATA device fell off, call sas_ata_device_link_abort() directly and
>> mark all outstanding QCs as failed and kick-off EH Immediately. This
>> avoids
>> having to wait for block layer timeouts.
>>
>> Signed-off-by: Xingui Yang <yangxingui@huawei.com>
>> ---
>>   drivers/scsi/libsas/sas_discover.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/scsi/libsas/sas_discover.c
>> b/drivers/scsi/libsas/sas_discover.c
>> index d5bc1314c341..bd22741daa99 100644
>> --- a/drivers/scsi/libsas/sas_discover.c
>> +++ b/drivers/scsi/libsas/sas_discover.c
>> @@ -362,6 +362,11 @@ static void sas_destruct_ports(struct
>> asd_sas_port *port)
>>   void sas_unregister_dev(struct asd_sas_port *port, struct
>> domain_device *dev)
>>   {
>> +    if (test_bit(SAS_DEV_GONE, &dev->state) &&
>> +        (dev->dev_type == SAS_SATA_DEV ||
>> +        (dev->tproto & SAS_PROTOCOL_STP)))
>
> dev_is_sata() would be better here.

ok, Thanks for your advice.

Thanks,
Xingui
>
> Thanks,
> Jason
>
>> +        sas_ata_device_link_abort(dev, false);
>> +
>>       if (!test_bit(SAS_DEV_DESTROY, &dev->state) &&
>>           !list_empty(&dev->disco_list_node)) {
>>           /* this rphy never saw sas_rphy_add */
>>
> .

\
 
 \ /
  Last update: 2022-12-16 10:54    [W:0.050 / U:1.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site