Messages in this thread |  | | From | David Laight <> | Subject | RE: [PATCH] RDMA/siw: fix pointer cast warning | Date | Thu, 15 Dec 2022 22:20:55 +0000 |
| |
From: Arnd Bergmann > Sent: 15 December 2022 17:04 > > From: Arnd Bergmann <arnd@arndb.de> > > The previous build fix left a remaining issue in configurations > with 64-bit dma_addr_t on 32-bit architectures: > > drivers/infiniband/sw/siw/siw_qp_tx.c: In function 'siw_get_pblpage': > drivers/infiniband/sw/siw/siw_qp_tx.c:32:37: error: cast to pointer from integer of different size [- > Werror=int-to-pointer-cast] > 32 | return virt_to_page((void *)paddr); > | ^ > > Use the same double cast here that the driver uses elsewhere > to convert between dma_addr_t and void*. > > It took me a while to figure out why this driver does it > like this, as there is no hardware access and it just stores > kernel pointers in place of device addresses when communicating > with the rdma core and with user space.
I hope that doesn't mean it is relying on user space only giving it back valid values?
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
|  |