Messages in this thread |  | | Date | Thu, 15 Dec 2022 11:43:28 -0700 | From | "Jason A. Donenfeld" <> | Subject | Re: [PATCH] m68k: string: Make char intermediate in strcmp() signed |
| |
On Thu, Dec 15, 2022 at 02:30:04PM +0100, Geert Uytterhoeven wrote: > Since char became unsigned, strcmp() always returns a positive number. > > "res" is used to store a byte difference, so it should be signed. > > Fixes: 3bc753c06dd02a35 ("kbuild: treat char as always unsigned") > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > --- > See "Re: [PATCH v9] kallsyms: Add self-test facility" > https://lore.kernel.org/r/CAMuHMdWM6+pC3yUqy+hHRrAf1BCz2sz1KQv2zxS+Wz-639X-aA@mail.gmail.com > > I'm wondering how many surprises like this are still hidden...
OOOOOOOOOOFFFFF! Not sure how I missed this one. Perhaps the ASM alluded the coccinelle scripts. Anyway, thanks for catching it, sorry for the bug, and here's my:
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
I assume you'll send this out for the next tranche of m68k fixes.
Jason
|  |