Messages in this thread |  | | Date | Thu, 15 Dec 2022 17:07:29 +0200 | Subject | Re: [PATCH v4 2/2] arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs | From | Dmitry Baryshkov <> |
| |
On 22/11/2022 00:15, Melody Olvera wrote: > > > On 11/21/2022 5:07 AM, Konrad Dybcio wrote: >> >> On 18.11.2022 20:22, Melody Olvera wrote: >>> Add DTs for Qualcomm IDP platforms using the QDU1000 and QRU1000 >>> SoCs. >>> >>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> >>> --- >>> arch/arm64/boot/dts/qcom/Makefile | 2 + >>> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 266 +++++++++++++++++++++++ >>> arch/arm64/boot/dts/qcom/qru1000-idp.dts | 266 +++++++++++++++++++++++ >>> 3 files changed, 534 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>> create mode 100644 arch/arm64/boot/dts/qcom/qru1000-idp.dts >>> >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >>> index afe496a93f94..da66d4a0a884 100644 >>> --- a/arch/arm64/boot/dts/qcom/Makefile >>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>> @@ -53,7 +53,9 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-maple.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += qru1000-idp.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sa8155p-adp.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sa8295p-adp.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc7180-idp.dtb >>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>> new file mode 100644 >>> index 000000000000..5aed483201fa >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>> @@ -0,0 +1,266 @@ >>> +// SPDX-License-Identifier: BSD-3-Clause >>> +/* >>> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >>> + */ >>> + >>> +/dts-v1/; >>> + >>> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> >>> +#include "qdu1000.dtsi" >>> +#include "pm8150.dtsi" >>> + >>> +/ { >>> + model = "Qualcomm Technologies, Inc. QDU1000 IDP"; >>> + compatible = "qcom,qdu1000-idp", "qcom,qdu1000"; >> Missing chassis-type > > Sorry, not sure what you mean here... Do you mean like QRD, HDK, MTP, etc.? > If so, then IDP is the chassis type. > >> >>> + >>> + aliases { >>> + serial0 = &uart7; >>> + }; >>> + >>> + clocks { >>> + xo_board: xo-board { >>> + compatible = "fixed-clock"; >>> + clock-frequency = <19200000>; >>> + clock-output-names = "xo_board"; >>> + #clock-cells = <0>; >>> + }; >>> + >>> + sleep_clk: sleep-clk { >>> + compatible = "fixed-clock"; >>> + clock-frequency = <32000>; >>> + #clock-cells = <0>; >>> + }; >>> + >>> + pcie_0_pipe_clk: pcie-0-pipe-clk { >>> + compatible = "fixed-clock"; >>> + clock-frequency = <1000>; >>> + clock-output-names = "pcie_0_pipe_clk"; >>> + #clock-cells = <0>; >>> + }; >>> + >>> + pcie_0_phy_aux_clk: pcie-0-phy-aux-clk { >>> + compatible = "fixed-clock"; >>> + clock-frequency = <1000>; >>> + clock-output-names = "pcie_0_phy_aux_clk"; >>> + #clock-cells = <0>; >>> + }; >>> + >>> + usb3_phy_wrapper_pipe_clk: usb3-phy-wrapper-pipe-clk { >>> + compatible = "fixed-clock"; >>> + clock-frequency = <1000>; >>> + clock-output-names = "usb3_phy_wrapper_pipe_clk"; >>> + #clock-cells = <0>; >>> + }; >> Do these pipe clocks not come from QMPPHY? > > Yes they do; I just don't have those phys ready yet. I can put a TODO here to > move them if necessary.
Just use <0> instead of adding a dummy fixed clock.
-- With best wishes Dmitry
|  |