lkml.org 
[lkml]   [2022]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] ASoC: max98088: fix initial dai mute state
On Thu, Dec 15, 2022 at 10:17:47AM +0100, Marco Felsch wrote:
> On 22-12-13, Mark Brown wrote:

> > > + snd_soc_component_update_bits(component, M98088_REG_2F_LVL_DAI1_PLAY,
> > > + M98088_DAI_MUTE_MASK, M98088_DAI_MUTE);
> > > + snd_soc_component_update_bits(component, M98088_REG_31_LVL_DAI2_PLAY,
> > > + M98088_DAI_MUTE_MASK, M98088_DAI_MUTE);
> > > +

> > Won't this be broken again after suspend? The device gets powered off
> > over suspend, then when it powers on again with the output unmuted
> > nothing will do another write since the register is already in the state
> > in the cache.

> I didn't found any suspend logic within the driver. Is this handled
> within the ASoC core?

Register save and restore for the device won't be.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-12-15 13:02    [W:0.081 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site