lkml.org 
[lkml]   [2022]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/7] staging: vc04_services: Drop VCHIQ_ERROR usage
From
Hi Umang,

thanks for taking care of this.

Am 15.12.22 um 07:58 schrieb Umang Jain:
> Drop the usage of VCHIQ_ERROR vchiq_status enum type. Replace it with
> -EINVAL to report the error.

I would prefer to use adequate error codes like ENOMEM and so on. I
agree simply replacing all VCHIQ_ERROR with -EINVAL is easier, but
wasn't the real intention of the TODO item.

The rest of the series looks good to me.

Best regards

\
 
 \ /
  Last update: 2022-12-15 12:39    [W:1.542 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site