lkml.org 
[lkml]   [2022]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 07/10] drm: bridge: it66121: Don't clear DDC FIFO twice
On Wed, 14 Dec 2022 at 13:59, Paul Cercueil <paul@crapouillou.net> wrote:
>
> The DDC FIFO was cleared before the loop in it66121_get_edid_block(),
> and at the beginning of each iteration; which means that it did not have
> to be cleared before the loop.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/gpu/drm/bridge/ite-it66121.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c
> index 06fa59ae5ffc..5335d4abd7c5 100644
> --- a/drivers/gpu/drm/bridge/ite-it66121.c
> +++ b/drivers/gpu/drm/bridge/ite-it66121.c
> @@ -456,18 +456,6 @@ static inline int it66121_wait_ddc_ready(struct it66121_ctx *ctx)
> return 0;
> }
>
> -static int it66121_clear_ddc_fifo(struct it66121_ctx *ctx)
> -{
> - int ret;
> -
> - ret = it66121_preamble_ddc(ctx);
> - if (ret)
> - return ret;
> -
> - return regmap_write(ctx->regmap, IT66121_DDC_COMMAND_REG,
> - IT66121_DDC_COMMAND_FIFO_CLR);
> -}
> -
> static int it66121_abort_ddc_ops(struct it66121_ctx *ctx)
> {
> int ret;
> @@ -515,10 +503,6 @@ static int it66121_get_edid_block(void *context, u8 *buf,
> offset = (block % 2) * len;
> block = block / 2;
>
> - ret = it66121_clear_ddc_fifo(ctx);
> - if (ret)
> - return ret;
> -
> while (remain > 0) {
> cnt = (remain > IT66121_EDID_FIFO_SIZE) ?
> IT66121_EDID_FIFO_SIZE : remain;
> --
> 2.35.1
>

Reviewed-by: Robert Foss <robert.foss@linaro.org>

\
 
 \ /
  Last update: 2022-12-15 12:21    [W:1.244 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site