Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 15 Dec 2022 09:22:28 +0000 | From | Marc Zyngier <> | Subject | Re: [PATCHv6 3/7] arm64: dts: rockchip: Add base DT for rk3588 SoC |
| |
On Wed, 14 Dec 2022 18:22:43 +0000, Sebastian Reichel <sebastian.reichel@collabora.com> wrote: > > From: Kever Yang <kever.yang@rock-chips.com> > > This initial version supports (single core) CPU, dma, interrupts, timers, > UART and SDHCI. In short - everything necessary to boot Linux on this > system on chip.
Single core? The DT indicates otherwise.
> > The DT is split into rk3588 and rk3588s, which is a reduced version > (i.e. with less peripherals) of the former. > > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com> > Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com> > Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com> > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > [rebase, squash and reword commit message] > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > arch/arm64/boot/dts/rockchip/rk3588.dtsi | 58 + > arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 1703 +++++++++++++++++++++ > 2 files changed, 1761 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3588.dtsi > create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s.dtsi >
[...]
> + gic: interrupt-controller@fe600000 { > + compatible = "arm,gic-v3"; > + reg = <0x0 0xfe600000 0 0x10000>, /* GICD */ > + <0x0 0xfe680000 0 0x100000>; /* GICR */ > + interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH 0>; > + interrupt-controller; > + mbi-alias = <0x0 0xfe610000>; > + mbi-ranges = <424 56>; > + msi-controller; > + #interrupt-cells = <4>; > + > + ppi-partitions { > + ppi_cluster0: interrupt-partition-0 { > + affinity = <&cpu_l0 &cpu_l1 &cpu_l2 &cpu_l3>; > + }; > + > + ppi_cluster1: interrupt-partition-1 { > + affinity = <&cpu_b0 &cpu_b1 &cpu_b2 &cpu_b3>;
The use of the word "cluster" is pretty misleading, specially as the actual CPU clusters don't align with this partitioning (you seem to have 2 independent A76 clusters). Consider using the word "partition", which was chosen exactly to avoid this confusion.
Thanks,
M.
-- Without deviation from the norm, progress is not possible.
| ![\](/images/icornerr.gif) |