lkml.org 
[lkml]   [2022]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] efitools: Include <strings.h> for the strcasecmp function
[+cc James]

On Wed, Dec 14, 2022 at 10:30:26PM +0100, Florian Weimer wrote:
> Otherwise, an implicit function declaration is the result, and the
> code may fail to compile with future compilers.
>
> ---
> efi-updatevar.c | 1 +
> 1 file changed, 1 insertion(+)

efitools appears to be maintained by James, so you may want to cc
your submissions to him.

Your patches are missing a DCO, yet existing commits in the efitools
repository have one. You may want to respin with your Signed-off-by
added.

Thanks,

Lukas

>
> diff --git a/efi-updatevar.c b/efi-updatevar.c
> index 4247105..033d938 100644
> --- a/efi-updatevar.c
> +++ b/efi-updatevar.c
> @@ -11,6 +11,7 @@
> #include <stdio.h>
> #include <stdlib.h>
> #include <string.h>
> +#include <strings.h>
> #include <sys/stat.h>
> #include <fcntl.h>
> #include <unistd.h>
>
> Related to:
>
> <https://fedoraproject.org/wiki/Changes/PortingToModernC>
> <https://fedoraproject.org/wiki/Toolchain/PortingToModernC>
>

\
 
 \ /
  Last update: 2022-12-14 22:44    [W:0.082 / U:0.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site