Messages in this thread |  | | Date | Wed, 14 Dec 2022 13:32:18 -0700 | From | "Jason A. Donenfeld" <> | Subject | Re: [PATCH] x86: lib: Separate instruction decoder MMIO type from MMIO trace |
| |
On Wed, Dec 14, 2022 at 11:56:29AM -0800, Ricardo Neri wrote: > > @@ -347,7 +347,7 @@ static int handle_mmio(struct pt_regs *regs, struct ve_info *ve) > > unsigned long *reg, val, vaddr; > > char buffer[MAX_INSN_SIZE]; > > struct insn insn = {}; > > - enum mmio_type mmio; > > + enum insn_mmio_type mmio; > > It would be good to preserve the reverse fir order in the variable > declarations. > > > - enum mmio_type mmio; > > + enum insn_mmio_type mmio; > > Same here.
Maintaining reverse Christmas trees would be in the holiday spirit, after all. I'll send a v2.
Jason
|  |