[lkml]   [2022]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v7] igb: Assign random MAC address instead of fail in case of invalid one
On Wed, Dec 14, 2022 at 08:51:06AM -0800, Jakub Kicinski wrote:
> On Wed, 14 Dec 2022 09:22:13 +0200 Leon Romanovsky wrote:
> > NAK to any module driver parameter. If it is applicable to all drivers,
> > please find a way to configure it to more user-friendly. If it is not,
> > try to do the same as other drivers do.
> I think this one may be fine. Configuration which has to be set before
> device probing can't really be per-device.

This configuration can be different between multiple devices
which use same igb module. Module parameters doesn't allow such

Also, as a user, I despise random module parameters which I need
to set after every HW update/replacement.


 \ /
  Last update: 2022-12-14 19:55    [W:0.137 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site