Messages in this thread | | | Date | Wed, 14 Dec 2022 09:24:06 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH v2 1/3] drivers: hwmon: Add max31732 quad remote temperature sensor driver |
| |
On 12/14/22 09:02, Krzysztof Kozlowski wrote: > On 14/12/2022 15:22, Sinan Divarci wrote: >> The MAX31732 is a multi-channel temperature sensor that monitors its own >> temperature and the temperatures of up to four external diodeconnected >> transistors. > > Use subject prefixes matching the subsystem (git log --oneline -- ...). > There is no such prefix as "drivers". > > I did not review the code, but it is easily visible that it does not > conform to Linux coding style wrapping at 80. Wrap at 80. >
I accept line lengths up to 100 to avoid excessive and misaligned continuation lines. As long as checkpatch --strict doesn't complain, I won't complain either. checkpatch --strict doesn't complain, and a brief look into the code tells me that - in terms of line length - it is fine. Please do not introduce additional continuation lines.
Thanks, Guenter
| |