lkml.org 
[lkml]   [2022]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3] block/blk-iocost (gcc13): keep large values in a new enum
From
On 12/13/22 5:08 AM, Jiri Slaby (SUSE) wrote:
> Since gcc13, each member of an enum has the same type as the enum [1]. And
> that is inherited from its members. Provided:
> VTIME_PER_SEC_SHIFT = 37,
> VTIME_PER_SEC = 1LLU << VTIME_PER_SEC_SHIFT,
> ...
> AUTOP_CYCLE_NSEC = 10LLU * NSEC_PER_SEC,
> the named type is unsigned long.
>
> This generates warnings with gcc-13:
> block/blk-iocost.c: In function 'ioc_weight_prfill':
> block/blk-iocost.c:3037:37: error: format '%u' expects argument of type 'unsigned int', but argument 4 has type 'long unsigned int'
>
> block/blk-iocost.c: In function 'ioc_weight_show':
> block/blk-iocost.c:3047:34: error: format '%u' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int'
>
> So split the anonumois enum with large values to a separate enum, so

anonymous?

--
Jens Axboe


\
 
 \ /
  Last update: 2022-12-14 17:58    [W:2.103 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site