Messages in this thread | | | Date | Wed, 14 Dec 2022 18:09:55 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 1/1] i2c: designware: set pinctrl recovery information from device pinctrl |
| |
On Wed, Dec 14, 2022 at 02:27:25PM +0000, Hanna Hawa wrote: > The current implementation of designware recovery mechanism fit for > specific device (Intel / Altera Cyclone V SOC) which have two separated > "wired" GPIOs to the i2c bus via the SOC FPGA for the i2c recovery. > > Make pinctrl recovery information to points to the device pinctrl by > setting the rinfo->pinctrl to dev->pins->p.
> Change Log v1->v2: > - set the rinfo->pinctrl to dev->pins->p instead calling > devm_pinctrl_get().
Wrong place for a changelog...
> Signed-off-by: Hanna Hawa <hhhawa@amazon.com> > ---
...should be located here.
...
> + if (dev->dev->pins && dev->dev->pins->p) > + rinfo->pinctrl = dev->dev->pins->p;
Hmm... I don't see how this field is being used. Can you elaborate?
-- With Best Regards, Andy Shevchenko
| |