lkml.org 
[lkml]   [2022]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v7] igb: Assign random MAC address instead of fail in case of invalid one
From
Date
hi Leon,

Currently this module parameter is only used for igb.
Is the more user-friendly way not to use module parameters?
just like other network card drivers, use random MAC.
As I submitted [patch v3] before, link:
https://lore.kernel.org/netdev/20220530105834.97175-1-lianglixuehao@126.com/

Or, can you suggest me how to do it more reasonable?

Thanks

> 2022年12月14日 15:22,Leon Romanovsky <leon@kernel.org> 写道:
>
> On Tue, Dec 13, 2022 at 07:47:26AM +0000, Lixue Liang wrote:
>> From: Lixue Liang <lianglixue@greatwall.com.cn>
>>
>> Add the module parameter "allow_invalid_mac_address" to control the
>> behavior. When set to true, a random MAC address is assigned, and the
>> driver can be loaded, allowing the user to correct the invalid MAC address.
>>
>> Signed-off-by: Lixue Liang <lianglixue@greatwall.com.cn>
>
>
> I'm amused that we are in v7 version of module parameter.
>
> NAK to any module driver parameter. If it is applicable to all drivers,
> please find a way to configure it to more user-friendly. If it is not,
> try to do the same as other drivers do.
>
> Thanks

\
 
 \ /
  Last update: 2022-12-14 11:07    [W:0.102 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site