lkml.org 
[lkml]   [2022]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v11 2/2] mfd: max597x: Add support for MAX5970 and MAX5978
From
Hi Lee

On 08-12-2022 05:53 pm, Lee Jones wrote:
> On Fri, 18 Nov 2022, Naresh Solanki wrote:
>
>>
>>
>> On 17-11-2022 03:45 pm, Lee Jones wrote:
>>> On Wed, 16 Nov 2022, Naresh Solanki wrote:
>>>
>>>> From: Patrick Rudolph <patrick.rudolph@9elements.com>
>>>>
>>>> Implement a regulator driver with IRQ support for fault management.
>>>> Written against documentation [1] and [2] and tested on real hardware.
>>>>
>>>> Every channel has its own regulator supplies nammed 'vss1-supply' and
>>>> 'vss2-supply'. The regulator supply is used to determine the output
>>>> voltage, as the smart switch provides no output regulation.
>>>> The driver requires the 'shunt-resistor-micro-ohms' property to be
>>>> present in Device Tree to properly calculate current related
>>>> values.
>>>>
>>>> Datasheet links:
>>>> 1: https://datasheets.maximintegrated.com/en/ds/MAX5970.pdf
>>>> 2: https://datasheets.maximintegrated.com/en/ds/MAX5978.pdf
>>>>
>>>> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
>>>> Co-developed-by: Marcello Sylvester Bauer <sylv@sylv.io>
>>>> Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
>>>> Co-developed-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>>>> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
>>>> ---
>>>> drivers/mfd/Kconfig | 12 +++++
>>>> drivers/mfd/Makefile | 1 +
>>>> drivers/mfd/max597x.c | 93 +++++++++++++++++++++++++++++++++
>>>> include/linux/mfd/max597x.h | 101 ++++++++++++++++++++++++++++++++++++
>>>> 4 files changed, 207 insertions(+)
>>>> create mode 100644 drivers/mfd/max597x.c
>>>> create mode 100644 include/linux/mfd/max597x.h
>>>
>>> Ignoring my comments won't make them go away. :)
>>>
>>> Please tell me why you need a whole new driver, instead of adding
>>> support to simple-mfd-i2c?
>>>
>> I felt current implementation to be simpler, clearer & straight forward.
>
> If you can make it work with simple-mfd-i2c, please do so.
simple-mfd-i2c doesn't has mechanism to pass device type(max5978 vs
max5970).
>
> No need to submit an entirely new driver for these simple use-cases.
>
Regards,
Naresh

\
 
 \ /
  Last update: 2022-12-14 09:41    [W:0.063 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site