Messages in this thread | | | From | Sudip Mukherjee <> | Date | Tue, 13 Dec 2022 17:47:53 +0000 | Subject | Re: [PATCH v2 14/15] spi: dt-bindings: snps,dw-ahb-ssi: Add generic dw-ahb-ssi version |
| |
On Tue, Dec 13, 2022 at 4:59 PM Mark Brown <broonie@kernel.org> wrote: > > On Tue, Dec 13, 2022 at 10:32:09AM -0600, Rob Herring wrote: > > On Mon, Dec 12, 2022 at 06:07:31PM +0000, Sudip Mukherjee wrote: > > > > Add new snps,dw-ahb-ssi version to the bindings. > > > Really, this should probably only be a fallback with an SoC specific > > compatible. Future quirk properties which are not board specific only > > will be rejected. You've been warned. > > Given how widely used DesignWare stuff is and usage in FPGAs it does > seem reasonable to have compatibles for just the IP rather than SoC > specific ones - we do have quirked versions that have been modified but > these are things that people manage to deploy without needing that and > SoC specific compatibles for FPGA instantiations would get painful.
Also, this patchset adds the autodetect procedure as discussed in the review of the previous series at https://lore.kernel.org/lkml/20220826233116.uulisbo663cxiadt@mobilestation/
So, we should be able to replace "snps,dw-apb-ssi" and "snps,dwc-ssi-1.01a" with "snps,dw-ahb-ssi" after this. And, also this generic compatible has been tested with the new 1.03a version we are working with, which was mentioned in my v1 at https://lore.kernel.org/lkml/20220826233305.5ugpukokzldum7y5@mobilestation/
-- Regards Sudip
| |