Messages in this thread Patch in this message | | | Date | Tue, 13 Dec 2022 10:32:09 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v2 14/15] spi: dt-bindings: snps,dw-ahb-ssi: Add generic dw-ahb-ssi version |
| |
On Mon, Dec 12, 2022 at 06:07:31PM +0000, Sudip Mukherjee wrote: > Add new snps,dw-ahb-ssi version to the bindings.
Yes, I can see that in the diff. Tell me something useful here. Why do we need a new compatible? What does this compatible imply in the h/w that the existing ones don't. How do I know which compatible to use?
Really, this should probably only be a fallback with an SoC specific compatible. Future quirk properties which are not board specific only will be rejected. You've been warned.
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@sifive.com> > --- > Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index d33b72fabc5d8..af36df67a4c0e 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -45,6 +45,7 @@ properties: > enum: > - snps,dw-apb-ssi > - snps,dwc-ssi-1.01a > + - snps,dw-ahb-ssi > - description: Microsemi Ocelot/Jaguar2 SoC SPI Controller > items: > - enum: > -- > 2.30.2 > >
| |