Messages in this thread |  | | Date | Tue, 13 Dec 2022 11:40:43 +0000 | | From | Mark Brown <> | | Subject | Re: [PATCH v1] spi: xtensa-xtfpga: Fix a double put() in xtfpga_spi_remove() |
| |
On Tue, Dec 13, 2022 at 09:30:32AM +0800, Yang Yingliang wrote: > On 2022/12/12 23:36, Mark Brown wrote: > > On Sat, Dec 10, 2022 at 06:48:02AM -0800, Max Filippov wrote:
> > Probably worth a comment though since it is a bit of a gotcha. Ideally > > we'd improve this in the bitbang code but that's harder.
> Ideally, spi_bitbang_stop() should undo spi_bitbang_start(). shall we move > spi_master_put() in spi_bitbang_stop() instead of > calling it separately in drivers?
Ideally like I say, there's issues with devm IIRC which make it more complicated than just adding a put() there. [unhandled content-type:application/pgp-signature] |  |