Messages in this thread |  | | Date | Mon, 12 Dec 2022 15:36:51 +0000 | | From | Mark Brown <> | | Subject | Re: [PATCH v1] spi: xtensa-xtfpga: Fix a double put() in xtfpga_spi_remove() |
| |
On Sat, Dec 10, 2022 at 06:48:02AM -0800, Max Filippov wrote: > Hi Christophe, > > On Sat, Dec 10, 2022 at 3:52 AM Christophe JAILLET > <christophe.jaillet@wanadoo.fr> wrote:
> > 'master' is allocated with devm_spi_alloc_master(), there is no need to > > put it explicitly in the remove function.
> > spi_bitbang_stop(&xspi->bitbang); > > - spi_master_put(master);
> This put is matching the get in the spi_bitbang_start. > It was discussed here: > https://lore.kernel.org/linux-spi/CAMo8BfJaD7pG_iutY8jordysjChyzhTpVSqpxXh3QoZsj2QmaQ@mail.gmail.com/
Probably worth a comment though since it is a bit of a gotcha. Ideally we'd improve this in the bitbang code but that's harder. [unhandled content-type:application/pgp-signature] |  |