Messages in this thread |  | | Date | Sat, 10 Dec 2022 19:56:41 +0100 | | Subject | Re: [PATCH 1/3] mmc: sunlpus: Fix an error handling path in spmmc_drv_probe() | | From | Christophe JAILLET <> |
| |
Le 10/12/2022 à 19:36, Christophe JAILLET a écrit : > If an error occurs after successful clk_prepare_enable() call in the probe, > the clk is not clk_disable_unprepare()'ed. > > Use devm_clk_get_enabled() instead of devm_clk_get() to fix, and simplify > the probe and the remove function accordingly. > > Fixes: 4e268fed8b18 ("mmc: Add mmc driver for Sunplus SP7021") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > This changes the order of resource releasing when the driver is removed, > but it looks ok to me. > --- > drivers/mmc/host/sunplus-mmc.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >
Hi, in the whole serie, the subject was supposed to be sunplus, not sunlpus. Could also be SP7021, or sunplus-SP7021, or whatever else.
I'll wait for potential comments on the patches themselves before sending a v2 to fix the subject (and I hope it could be fixed when applied if there is no comment :))
CJ
|  |