Messages in this thread | | | Date | Tue, 8 Nov 2022 17:56:29 +0100 | Subject | Re: [PATCH v2 2/2] clk: qcom: Add SC8280XP display clock controller | From | Konrad Dybcio <> |
| |
On 26/09/2022 22:38, Bjorn Andersson wrote: > From: Bjorn Andersson <bjorn.andersson@linaro.org> > > The Qualcomm SC8280XP platform has two display clock controller > instances, add support for these. Duplication between the two > implementations is reduced by reusing any constant data between the two > sets of clock data. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> > --- Just a couple of bits:
- Use lowercase hex in constants - I'm not sure I like hacking clocks up with magic writes.. this driver can and will be compiled as a module by default and that prevents a de-facto clean removal.
Other than that: Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
| |