Messages in this thread | | | Date | Fri, 4 Nov 2022 11:53:53 +0800 | From | Cai Huoqing <> | Subject | Re: [PATCH net-next v2 1/2] net: hinic: Convert the cmd code from decimal to hex to be more readable |
| |
On 02 11月 22 20:36:40, Jakub Kicinski wrote: > On Tue, 1 Nov 2022 14:03:38 +0800 Cai Huoqing wrote: > > The print cmd code is in hex, so using hex cmd code intead of > > decimal is easy to check the value with print info. > > You're still removing empty lines making this patch much harder > to review. Once again - it should be a pure conversion to dec -> hex. > Don't make any other changes. Hi, Jakub
I fix it, and resend v4 https://lore.kernel.org/lkml/20221103080525.26885-1-cai.huoqing@linux.dev/
Thanks, Cai
| |