Messages in this thread | ![/](/images/icornerl.gif) | | From | "Rafael J. Wysocki" <> | Date | Thu, 3 Nov 2022 19:39:29 +0100 | Subject | Re: [PATCH 14/30] powercap: Use kstrtobool() instead of strtobool() |
| |
On Tue, Nov 1, 2022 at 10:15 PM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > strtobool() is the same as kstrtobool(). > However, the latter is more used within the kernel. > > In order to remove strtobool() and slightly simplify kstrtox.h, switch to > the other function name. > > While at it, include the corresponding header file (<linux/kstrtox.h>) > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > This patch is part of a serie that axes all usages of strtobool(). > Each patch can be applied independently from the other ones. > > The last patch of the serie removes the definition of strtobool(). > > You may not be in copy of the cover letter. So, if needed, it is available > at [1]. > > [1]: https://lore.kernel.org/all/cover.1667336095.git.christophe.jaillet@wanadoo.fr/ > --- > drivers/powercap/powercap_sys.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c > index f0654a932b37..1f968353d479 100644 > --- a/drivers/powercap/powercap_sys.c > +++ b/drivers/powercap/powercap_sys.c > @@ -7,6 +7,7 @@ > #include <linux/module.h> > #include <linux/device.h> > #include <linux/err.h> > +#include <linux/kstrtox.h> > #include <linux/slab.h> > #include <linux/powercap.h> > > @@ -446,7 +447,7 @@ static ssize_t enabled_store(struct device *dev, > { > bool mode; > > - if (strtobool(buf, &mode)) > + if (kstrtobool(buf, &mode)) > return -EINVAL; > if (dev->parent) { > struct powercap_zone *power_zone = to_powercap_zone(dev); > --
Applied as 6.2 material, thanks!
| ![\](/images/icornerr.gif) |