Messages in this thread | | | Date | Tue, 29 Nov 2022 19:51:46 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net-next 04/12] net: dpaa2-mac: remove defensive check in dpaa2_mac_disconnect() |
| |
On Tue, Nov 29, 2022 at 04:12:13PM +0200, Vladimir Oltean wrote: > dpaa2_mac_disconnect() will only be called with a NULL mac->phylink if > dpaa2_mac_connect() failed, or was never called. > > The callers are these: > > dpaa2_eth_disconnect_mac(): > > if (dpaa2_eth_is_type_phy(priv)) > dpaa2_mac_disconnect(priv->mac); > > dpaa2_switch_port_disconnect_mac(): > > if (dpaa2_switch_port_is_type_phy(port_priv)) > dpaa2_mac_disconnect(port_priv->mac); > > priv->mac can be NULL, but in that case, dpaa2_eth_is_type_phy() returns > false, and dpaa2_mac_disconnect() is never called. Similar for > dpaa2-switch. > > When priv->mac is non-NULL, it means that dpaa2_mac_connect() returned > zero (success), and therefore, priv->mac->phylink is also a valid > pointer. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
| |