Messages in this thread | | | Date | Tue, 29 Nov 2022 20:33:56 +0200 | From | Vladimir Oltean <> | Subject | Re: [PATCH linux-next v2] net: stmmac: use sysfs_streq() instead of strncmp() |
| |
On Tue, Nov 29, 2022 at 07:25:41PM +0100, Andrew Lunn wrote: > > With strncmp("tc:", 3), the code matches on the "tc:1" token properly. > > With sysfs_streq("tc:"), it doesn't. > > It is not clear you have addressed this point.
As they say, "let sleeping dogs cry". I'm not sure that we should be making (especially untested) changes in the cmdline handling there.
| |