Messages in this thread | | | From | Mark Hasemeyer <> | Date | Tue, 29 Nov 2022 11:13:04 -0700 | Subject | Re: [PATCH v7 3/3] platform/chrome: cros_ec_uart: Add DT enumeration support |
| |
> > @@ -392,6 +393,12 @@ static int __maybe_unused cros_ec_uart_resume(struct device *dev) > > static SIMPLE_DEV_PM_OPS(cros_ec_uart_pm_ops, cros_ec_uart_suspend, > > cros_ec_uart_resume); > > > > +static const struct of_device_id cros_ec_uart_of_match[] = { > > + { .compatible = "google,cros-ec-uart" }, > > + {} > > +}; > > +MODULE_DEVICE_TABLE(of, cros_ec_uart_of_match); > > It would need a guard for checking CONFIG_OF. Similar to what > `cros_ec_uart_acpi_id` does. > > > @@ -405,6 +412,7 @@ static struct serdev_device_driver cros_ec_uart_driver = { > > .driver = { > > .name = "cros-ec-uart", > > .acpi_match_table = ACPI_PTR(cros_ec_uart_acpi_id), > > + .of_match_table = cros_ec_uart_of_match, > > It would need be wrapped by `of_match_ptr()`. Similar to what > `ACPI_PTR()` does.
I'm not sure we want a guard in this case because we compile the kernel without CONFIG_OF enabled for (most?) x86 platforms. Yet we still need the device tree code to enumerate using the PRP0001 _HID method.
| |