lkml.org 
[lkml]   [2022]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 08/11] wifi: rtw88: Add rtw8821cu chipset support
From
On 11/29/22 10:17, Jakub Kicinski wrote:
> On Tue, 29 Nov 2022 11:07:51 +0100 Sascha Hauer wrote:
>> +config RTW88_8821CU
>> + tristate "Realtek 8821CU USB wireless network adapter"
>> + depends on USB
>> + select RTW88_CORE
>> + select RTW88_USB
>> + select RTW88_8821C
>> + help
>> + Select this option will enable support for 8821CU chipset
>> +
>> + 802.11ac USB wireless network adapter
>
> Those kconfig knobs add so little code, why not combine them all into
> one? No point bothering the user with 4 different questions with amount
> to almost nothing.

I see only one knob there, name RTW88_8821CU. The other configuration variables
select parts of the code that are shared with other drivers such as RTW88_8821CE
and these parts must be there.

Larry

\
 
 \ /
  Last update: 2022-11-29 18:03    [W:0.105 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site