Messages in this thread | | | Date | Tue, 29 Nov 2022 08:38:26 -0800 | Subject | Re: [PATCH v2 2/6] ABI: sysfs-class-hwmon: add a description for fanY_fault | From | Guenter Roeck <> |
| |
On 11/29/22 08:15, Hawkins, Nick wrote: >> This change is really completely unrelated to a CPLD or specific SoC. >> The commit description is just confusing. It should simply state that >> it documents the existing fanX_fault attribute. > > Understood. Just to confirm should I change fanY_fault to fanX_fault > in documentation as well as the patch description? For instance: > /sys/class/hwmon/hwmonX/fanX_fault > > It seems that the documentation around it uses fanY_ format. >
Now you start splitting hairs ;-). I wanted to point out that fan[X,Y,Z,A,B,C,...]_fault is a generic attribute, not that I want you to change fanY to fanX.
Guenter
| |