lkml.org 
[lkml]   [2022]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ASoC: qcom: lpass-sc7180: Add maybe_unused tag for system PM ops
On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote:
> Add __maybe_unused tag for system PM ops suspend and resume.
> This is required to fix allmodconfig compilation issue.
> Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops")
>
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>

A better solution would be replacing SET_SYSTEM_SLEEP_PM_OPS() with
SYSTEM_SLEEP_PM_OPS(), which was added to avoid needing to add these
'__maybe_unused' attributes to these functions. See commit 1a3c7bb08826
("PM: core: Add new *_PM_OPS macros, deprecate old ones") for more info.

> ---
> sound/soc/qcom/lpass-sc7180.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
> index b96b85a..41db661 100644
> --- a/sound/soc/qcom/lpass-sc7180.c
> +++ b/sound/soc/qcom/lpass-sc7180.c
> @@ -163,14 +163,14 @@ static int sc7180_lpass_exit(struct platform_device *pdev)
> return 0;
> }
>
> -static int sc7180_lpass_dev_resume(struct device *dev)
> +static int __maybe_unused sc7180_lpass_dev_resume(struct device *dev)
> {
> struct lpass_data *drvdata = dev_get_drvdata(dev);
>
> return clk_bulk_prepare_enable(drvdata->num_clks, drvdata->clks);
> }
>
> -static int sc7180_lpass_dev_suspend(struct device *dev)
> +static int __maybe_unused sc7180_lpass_dev_suspend(struct device *dev)
> {
> struct lpass_data *drvdata = dev_get_drvdata(dev);
>
> --
> 2.7.4
>
>

\
 
 \ /
  Last update: 2022-11-29 16:46    [W:0.087 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site