Messages in this thread | | | Date | Tue, 29 Nov 2022 09:43:10 +0100 | From | "" <> | Subject | Re: [PATCH] nvme: clear the prp2 field of the nvme command. |
| |
On Tue, Nov 29, 2022 at 12:50:57PM +0800, Rao, Lei wrote: > stricter checks, and if prp2 is not used but has a value, some warnings will be > printed. According to the NVMe spec, it seems to write a reserved field produces > an undefined result, so maybe clearing it is better.
NVMe is a little weird about reserved fields settable by the host. I don't think your controllers warnings are correct, but given that the cost of clearing is very low I think we should clear it in Linux. Please resend a patch with the clearing in the right place as suggested in my previous mail.
| |