lkml.org 
[lkml]   [2022]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] driver core: fix up some missing class.devnode() conversions.
On Tue, Nov 29, 2022 at 06:33:04AM +0000, Christophe Leroy wrote:
>
>
> Le 28/11/2022 à 18:35, Greg Kroah-Hartman a écrit :
> > In commit ff62b8e6588f ("driver core: make struct class.devnode() take a
> > const *") the ->devnode callback changed the pointer to be const, but a
> > few instances of PowerPC drivers were not caught for some reason.
> >
> > Fix this up by changing the pointers to be const.
>
> Build fails:
>
> /linux/arch/powerpc/platforms/book3s/vas-api.c: In function
> 'vas_register_coproc_api':
> /linux/arch/powerpc/platforms/book3s/vas-api.c:590:31: error: assignment
> from incompatible pointer type [-Werror=incompatible-pointer-types]
> coproc_device.class->devnode = coproc_devnode;
> ^
> cc1: all warnings being treated as errors

What did you build this against? It has to be be against my
driver-core-next tree as that is where the Fixes: commit is.

thanks,

greg k-h

\
 
 \ /
  Last update: 2022-11-29 09:28    [W:0.042 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site