Messages in this thread | | | Date | Wed, 30 Nov 2022 02:42:40 +0100 | From | "Jason A. Donenfeld" <> | Subject | Re: [PATCH v10 1/4] random: add vgetrandom_alloc() syscall |
| |
On Wed, Nov 30, 2022 at 02:37:32AM +0100, Thomas Gleixner wrote: > On Wed, Nov 30 2022 at 01:59, Jason A. Donenfeld wrote: > > On Tue, Nov 29, 2022 at 11:02:29PM +0100, Thomas Gleixner wrote: > >> > + * Returns a pointer to the first state in the allocation. > >> > >> I have serious doubts that this statement is correct. > > > > "Returns the address of the first state in the allocation" is better I > > guess. > > Does not even come close to correct. > > As my previous hint of 'using this as template for the (hint:missing) > man page' did not work well, may I suggest that you look at the various > return statements in that function and validate whether your proposed > return value documentation is valid for all of them?
Ahh, the error values and such. Righto. Will do. I'll match the style of similar functions.
Jason
| |