lkml.org 
[lkml]   [2022]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/3] selftests: Make a warning if getcpu is missing on 32bit.
From
On 11/25/22 02:42, Sebastian Andrzej Siewior wrote:
> The vsyscall for getcpu has been wired up on 32bit so it can be warned
> now if missing.
>
> Cc: Shuah Khan <shuah@kernel.org>
> Cc: linux-kselftest@vger.kernel.org
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> tools/testing/selftests/x86/test_vsyscall.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/tools/testing/selftests/x86/test_vsyscall.c b/tools/testing/selftests/x86/test_vsyscall.c
> index 5b45e6986aeab..47cab972807c4 100644
> --- a/tools/testing/selftests/x86/test_vsyscall.c
> +++ b/tools/testing/selftests/x86/test_vsyscall.c
> @@ -92,11 +92,8 @@ static void init_vdso(void)
> printf("[WARN]\tfailed to find time in vDSO\n");
>
> vdso_getcpu = (getcpu_t)dlsym(vdso, "__vdso_getcpu");
> - if (!vdso_getcpu) {
> - /* getcpu() was never wired up in the 32-bit vDSO. */
> - printf("[%s]\tfailed to find getcpu in vDSO\n",
> - sizeof(long) == 8 ? "WARN" : "NOTE");
> - }
> + if (!vdso_getcpu)
> + printf("[WARN]\tfailed to find getcpu in vDSO\n");
> }
>
> static int init_vsys(void)

Assuming this is going through x86 tree due to dependencies, here is
my ack

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

Let me know if you would like to me pick this up.

thanks,
-- Shuah

\
 
 \ /
  Last update: 2022-11-29 22:55    [W:0.109 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site