Messages in this thread | | | Date | Mon, 28 Nov 2022 15:08:01 +0800 | Subject | Re: [PATCH] selftests/tls: Fix tls selftests dependency to correct algorithm | From | Tianjia Zhang <> |
| |
Hi Bagas,
On 11/25/22 9:18 PM, Bagas Sanjaya wrote: > On Fri, Nov 25, 2022 at 08:19:05PM +0800, Tianjia Zhang wrote: >> Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") moves >> the SM3 and SM4 stand-alone library and the algorithm implementation for >> the Crypto API into the same directory, and the corresponding relationship >> of Kconfig is modified, CONFIG_CRYPTO_SM3/4 corresponds to the stand-alone >> library of SM3/4, and CONFIG_CRYPTO_SM3/4_GENERIC corresponds to the >> algorithm implementation for the Crypto API. Therefore, it is necessary >> for this module to depend on the correct algorithm. >> > > I feel a rather confused. What about below? > > ``` > Commit <commit> moves SM3 and SM4 algorithm implementations from > stand-alone library to crypto API. The corresponding configuration > options for the API version (generic) are CONFIG_CRYPTO_SM3_GENERIC and > CONFIG_CRYPTO_SM4_GENERIC, respectively. > > Replace option selected in selftests configuration from the library version > to the API version. > ``` >
Thanks, this is great, I will pick it up.
>> Fixes: d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") >> Cc: Jason A. Donenfeld <Jason@zx2c4.com> >> Cc: stable@vger.kernel.org # v5.19+ >> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com> >> --- >> tools/testing/selftests/net/config | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config >> index ead7963b9bf0..bd89198cd817 100644 >> --- a/tools/testing/selftests/net/config >> +++ b/tools/testing/selftests/net/config >> @@ -43,5 +43,5 @@ CONFIG_NET_ACT_TUNNEL_KEY=m >> CONFIG_NET_ACT_MIRRED=m >> CONFIG_BAREUDP=m >> CONFIG_IPV6_IOAM6_LWTUNNEL=y >> -CONFIG_CRYPTO_SM4=y >> +CONFIG_CRYPTO_SM4_GENERIC=y >> CONFIG_AMT=m > > You mean the correct algo option is CONFIG_CRYPTO_SM4_GENERIC, right? >
Yes, CONFIG_CRYPTO_SM4_GENERIC is the correct algo option.
Best regards, Tianjia
| |