Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH 8/9] dt-bindings: mtd: Split ECC engine with rawnand controller | Date | Mon, 28 Nov 2022 06:20:47 -0600 |
| |
On Mon, 28 Nov 2022 10:06:12 +0800, Xiangsheng Hou wrote: > Split MediaTek ECC engine with rawnand controller and convert to > YAML schema. > > Signed-off-by: Xiangsheng Hou <xiangsheng.hou@mediatek.com> > --- > .../bindings/mtd/mtk,nand-ecc-engine.yaml | 60 ++++++ > .../devicetree/bindings/mtd/mtk-nand.txt | 176 ------------------ > .../devicetree/bindings/mtd/mtk-nand.yaml | 92 +++++++++ > 3 files changed, 152 insertions(+), 176 deletions(-) > create mode 100644 Documentation/devicetree/bindings/mtd/mtk,nand-ecc-engine.yaml > delete mode 100644 Documentation/devicetree/bindings/mtd/mtk-nand.txt > create mode 100644 Documentation/devicetree/bindings/mtd/mtk-nand.yaml >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/mtk-nand.yaml: properties:clock-names: 'oneOf' conditional failed, one must be fixed: [{'const': 'nfi_clk'}, {'const': 'pad_clk'}] is too long [{'const': 'nfi_clk'}, {'const': 'pad_clk'}] is too short False schema does not allow 2 1 was expected hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/mtk-nand.yaml: properties:clocks: 'oneOf' conditional failed, one must be fixed: [{'description': 'clock used for the controller'}, {'description': 'clock used for the pad'}] is too long [{'description': 'clock used for the controller'}, {'description': 'clock used for the pad'}] is too short False schema does not allow 2 1 was expected hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/mtk,nand-ecc-engine.yaml: properties:clocks: 'oneOf' conditional failed, one must be fixed: [{'description': 'clock used for the controller'}] is too short False schema does not allow 1 hint: "minItems" is only needed if less than the "items" list length from schema $id: http://devicetree.org/meta-schemas/items.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/mtk-nand.example.dtb: nfi@1100d000: $nodename:0: 'nfi@1100d000' does not match '^nand-controller(@.*)?' From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/mtk-nand.yaml
doc reference errors (make refcheckdocs): Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/mtd/mtk-nand.txt MAINTAINERS: Documentation/devicetree/bindings/mtd/mtk-nand.txt
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221128020613.14821-9-xiangsheng.hou@mediatek.com
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command.
| |