lkml.org 
[lkml]   [2022]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v1 03/26] net: dsa: microchip: ksz8: ksz8_fdb_dump: fix not complete fdb extraction
    Date
    Current ksz8_fdb_dump() is able to extract max 249 entries on
    the ksz8863/ksz8873 series of switches. This happened due to wrong
    bit mask and offset calculation.

    With this patch, we will be able to extract all possible 1024 entries.

    Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
    ---
    drivers/net/dsa/microchip/ksz_common.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c
    index 423f944cc34c..43d94131417b 100644
    --- a/drivers/net/dsa/microchip/ksz_common.c
    +++ b/drivers/net/dsa/microchip/ksz_common.c
    @@ -398,10 +398,10 @@ static const u32 ksz8863_masks[] = {
    [STATIC_MAC_TABLE_FID] = GENMASK(29, 26),
    [STATIC_MAC_TABLE_OVERRIDE] = BIT(20),
    [STATIC_MAC_TABLE_FWD_PORTS] = GENMASK(18, 16),
    - [DYNAMIC_MAC_TABLE_ENTRIES_H] = GENMASK(5, 0),
    + [DYNAMIC_MAC_TABLE_ENTRIES_H] = GENMASK(1, 0),
    [DYNAMIC_MAC_TABLE_MAC_EMPTY] = BIT(7),
    [DYNAMIC_MAC_TABLE_NOT_READY] = BIT(7),
    - [DYNAMIC_MAC_TABLE_ENTRIES] = GENMASK(31, 28),
    + [DYNAMIC_MAC_TABLE_ENTRIES] = GENMASK(31, 24),
    [DYNAMIC_MAC_TABLE_FID] = GENMASK(19, 16),
    [DYNAMIC_MAC_TABLE_SRC_PORT] = GENMASK(21, 20),
    [DYNAMIC_MAC_TABLE_TIMESTAMP] = GENMASK(23, 22),
    @@ -411,7 +411,7 @@ static u8 ksz8863_shifts[] = {
    [VLAN_TABLE_MEMBERSHIP_S] = 16,
    [STATIC_MAC_FWD_PORTS] = 16,
    [STATIC_MAC_FID] = 22,
    - [DYNAMIC_MAC_ENTRIES_H] = 3,
    + [DYNAMIC_MAC_ENTRIES_H] = 8,
    [DYNAMIC_MAC_ENTRIES] = 24,
    [DYNAMIC_MAC_FID] = 16,
    [DYNAMIC_MAC_TIMESTAMP] = 24,
    --
    2.30.2
    \
     
     \ /
      Last update: 2022-11-28 13:02    [W:4.771 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site