Messages in this thread | | | From | "Keller, Jacob E" <> | Subject | RE: [PATCH net-next v5 2/4] net: devlink: remove devlink_info_driver_name_put() | Date | Tue, 29 Nov 2022 01:19:46 +0000 |
| |
> -----Original Message----- > From: Vincent MAILHOL <mailhol.vincent@wanadoo.fr> > Sent: Monday, November 28, 2022 5:11 PM > To: Keller, Jacob E <jacob.e.keller@intel.com> > Cc: Jiri Pirko <jiri@nvidia.com>; netdev@vger.kernel.org; Jakub Kicinski > <kuba@kernel.org>; David S . Miller <davem@davemloft.net>; Eric Dumazet > <edumazet@google.com>; Paolo Abeni <pabeni@redhat.com>; linux- > kernel@vger.kernel.org; Boris Brezillon <bbrezillon@kernel.org>; Arnaud Ebalard > <arno@natisbad.org>; Srujana Challa <schalla@marvell.com>; Kurt Kanzenbach > <kurt@linutronix.de>; Andrew Lunn <andrew@lunn.ch>; Florian Fainelli > <f.fainelli@gmail.com>; Vladimir Oltean <olteanv@gmail.com>; Michael Chan > <michael.chan@broadcom.com>; Ioana Ciornei <ioana.ciornei@nxp.com>; > Dimitris Michailidis <dmichail@fungible.com>; Yisen Zhuang > <yisen.zhuang@huawei.com>; Salil Mehta <salil.mehta@huawei.com>; > Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L > <anthony.l.nguyen@intel.com>; Sunil Goutham <sgoutham@marvell.com>; Linu > Cherian <lcherian@marvell.com>; Geetha sowjanya <gakula@marvell.com>; > Jerin Jacob <jerinj@marvell.com>; hariprasad <hkelam@marvell.com>; > Subbaraya Sundeep <sbhatta@marvell.com>; Taras Chornyi > <tchornyi@marvell.com>; Saeed Mahameed <saeedm@nvidia.com>; Leon > Romanovsky <leon@kernel.org>; Ido Schimmel <idosch@nvidia.com>; Petr > Machata <petrm@nvidia.com>; Simon Horman <simon.horman@corigine.com>; > Shannon Nelson <snelson@pensando.io>; drivers@pensando.io; Ariel Elior > <aelior@marvell.com>; Manish Chopra <manishc@marvell.com>; Jonathan > Lemon <jonathan.lemon@gmail.com>; Vadim Fedorenko <vadfed@fb.com>; > Richard Cochran <richardcochran@gmail.com>; Vadim Pasternak > <vadimp@mellanox.com>; linux-crypto@vger.kernel.org; intel-wired- > lan@lists.osuosl.org; linux-rdma@vger.kernel.org; oss-drivers@corigine.com; Jiri > Pirko <jiri@mellanox.com>; Herbert Xu <herbert@gondor.apana.org.au>; > Guangbin Huang <huangguangbin2@huawei.com>; Minghao Chi > <chi.minghao@zte.com.cn>; Shijith Thotton <sthotton@marvell.com> > Subject: Re: [PATCH net-next v5 2/4] net: devlink: remove > devlink_info_driver_name_put() > > Hi Jacob, > > Thanks for the review! > > On Tue. 29 Nov. 2022 at 09:23, Keller, Jacob E <jacob.e.keller@intel.com> wrote: > > > -----Original Message----- > > > From: Vincent Mailhol <vincent.mailhol@gmail.com> On Behalf Of Vincent > > > Mailhol > > > Sent: Monday, November 28, 2022 4:06 PM > > > To: Jiri Pirko <jiri@nvidia.com>; netdev@vger.kernel.org; Jakub Kicinski > > > <kuba@kernel.org> > > > Cc: David S . Miller <davem@davemloft.net>; Eric Dumazet > > > <edumazet@google.com>; Paolo Abeni <pabeni@redhat.com>; linux- > > > kernel@vger.kernel.org; Boris Brezillon <bbrezillon@kernel.org>; Arnaud > Ebalard > > > <arno@natisbad.org>; Srujana Challa <schalla@marvell.com>; Kurt > Kanzenbach > > > <kurt@linutronix.de>; Andrew Lunn <andrew@lunn.ch>; Florian Fainelli > > > <f.fainelli@gmail.com>; Vladimir Oltean <olteanv@gmail.com>; Michael Chan > > > <michael.chan@broadcom.com>; Ioana Ciornei <ioana.ciornei@nxp.com>; > > > Dimitris Michailidis <dmichail@fungible.com>; Yisen Zhuang > > > <yisen.zhuang@huawei.com>; Salil Mehta <salil.mehta@huawei.com>; > > > Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L > > > <anthony.l.nguyen@intel.com>; Sunil Goutham <sgoutham@marvell.com>; > Linu > > > Cherian <lcherian@marvell.com>; Geetha sowjanya <gakula@marvell.com>; > > > Jerin Jacob <jerinj@marvell.com>; hariprasad <hkelam@marvell.com>; > > > Subbaraya Sundeep <sbhatta@marvell.com>; Taras Chornyi > > > <tchornyi@marvell.com>; Saeed Mahameed <saeedm@nvidia.com>; Leon > > > Romanovsky <leon@kernel.org>; Ido Schimmel <idosch@nvidia.com>; Petr > > > Machata <petrm@nvidia.com>; Simon Horman > <simon.horman@corigine.com>; > > > Shannon Nelson <snelson@pensando.io>; drivers@pensando.io; Ariel Elior > > > <aelior@marvell.com>; Manish Chopra <manishc@marvell.com>; Jonathan > > > Lemon <jonathan.lemon@gmail.com>; Vadim Fedorenko <vadfed@fb.com>; > > > Richard Cochran <richardcochran@gmail.com>; Vadim Pasternak > > > <vadimp@mellanox.com>; Shalom Toledo <shalomt@mellanox.com>; linux- > > > crypto@vger.kernel.org; intel-wired-lan@lists.osuosl.org; linux- > > > rdma@vger.kernel.org; oss-drivers@corigine.com; Jiri Pirko > > > <jiri@mellanox.com>; Herbert Xu <herbert@gondor.apana.org.au>; Hao > Chen > > > <chenhao288@hisilicon.com>; Guangbin Huang > > > <huangguangbin2@huawei.com>; Minghao Chi <chi.minghao@zte.com.cn>; > > > Shijith Thotton <sthotton@marvell.com>; Vincent Mailhol > > > <mailhol.vincent@wanadoo.fr> > > > Subject: [PATCH net-next v5 2/4] net: devlink: remove > > > devlink_info_driver_name_put() > > > > > > Now that the core sets the driver name attribute, drivers are not > > > supposed to call devlink_info_driver_name_put() anymore. Remove it. > > > > > > > You could combine this patch with the previous one so that in the event of a > cherry-pick its not possible to have this function while the core inserts the driver > name automatically. > > > > I think that also makes it very clear that there are no remaining in-tree drivers > still calling the function. > > > > I don't have a strong preference if we prefer it being separated. > > The first patch is already pretty long. I do not expect this to be > cherry-picked because it does not fix any existing bug (and if people > really want to cherry pick, then they just have to cherry pick both). > On the contrary, splitting makes it easier to review, I think. > > Unless the maintainers as me to squash, I want to keep it as-is. >
That works for me!
Thanks, Jake
> > Yours sincerely, > Vincent Mailhol
| |