Messages in this thread | | | Date | Mon, 28 Nov 2022 14:10:56 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from asm-offsets.c |
| |
On Mon, 28 Nov 2022 18:06:18 +0000 Sean Christopherson <seanjc@google.com> wrote:
> > > IIRC, the reason for adding that was because that logic was screwing up > > > asm-offsets.c. I'm not sure it screws up kvm-asm-offsets.c though. > > > > > > This is one of those cases I wish I commented that code better :-/ > > > > I don't think KVM includes linux/ftrace.h or asm/ftrace.h at all. > > >From include/linux/kvm_host.h > > #include <linux/ftrace.h> > > Even if that didn't exist, saying that XYZ never includes a header is a dangerous > business, it's all too easy to indirectly include headers in the kernel, now or > in the future.
But going back to the original intent of COMPILE_OFFSETS. I believe it was because some code that did not work with the auto generation of compiler offsets and was a way to hide them.
I do not know if it is still an issue or not today.
-- Steve
| |