Messages in this thread | | | Subject | Re: [PATCH] tracing: Fix infinite loop in tracing_read_pipe on overflowed print_trace_line | From | Yang Jihong <> | Date | Thu, 24 Nov 2022 21:04:06 +0800 |
| |
Hello,
On 2022/11/21 3:49, Steven Rostedt wrote: > On Fri, 18 Nov 2022 18:21:12 +0800 > Yang Jihong <yangjihong1@huawei.com> wrote: > >>> That way we can see the broken trace event and not just silently drop it. >>> >> Ok, will change in next version.(Because iter->seq.seq.len may be >> smaller than strlen(dots), direct subtraction here may not be appropriate.) > > We should only need to do this if the len is maxed out. > > Hmm, len is only updated if it did actually copy it. > > Perhaps we could just add: > > trace_seq_puts(&iter->seq, "[LINE TOO BIG]\n"); > The v3 patch has been sent according to this solution.
Thanks, Yang
| |