Messages in this thread | | | Date | Wed, 23 Nov 2022 11:35:17 +0100 | From | Tommaso Merciai <> | Subject | Re: [PATCH resend] media: staging: stkwebcam: Restore MEDIA_{USB,CAMERA}_SUPPORT dependencies |
| |
Hi Gaert,
On Wed, Nov 23, 2022 at 11:13:31AM +0100, Geert Uytterhoeven wrote: > Hi Tommaso, > > On Wed, Nov 23, 2022 at 11:08 AM Tommaso Merciai > <tommaso.merciai@amarulasolutions.com> wrote: > > On Mon, Nov 21, 2022 at 04:58:33PM +0100, Geert Uytterhoeven wrote: > > > By moving support for the USB Syntek DC1125 Camera to staging, the > > > dependencies on MEDIA_USB_SUPPORT and MEDIA_CAMERA_SUPPORT were lost. > > > > > > Fixes: 56280c64ecacc971 ("media: stkwebcam: deprecate driver, move to staging") > > > > Patch itself looks good but we have some style issue. Applying this > > patch I got the following warning from checkpatchl: > > > > WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 56280c64ecac ("media: stkwebcam: deprecate driver, move to staging")' > > #10: > > > > You have to pass only the first 12 chars of the sha1 commit into Fixes > > msg: > > > > Use: > > > > Fixes: 56280c64ecac ("media: stkwebcam: deprecate driver, move to staging") > > > > Instead of: > > > > Fixes: 56280c64ecacc971 ("media: stkwebcam: deprecate driver, move to staging") > > I always use 16 chars, to avoid these becoming ambiguous in a few years. > > Gr{oetje,eeting}s,
Thanks for sharing this info.
Regards, Tommaso
> > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
-- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________
Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com
| |