Messages in this thread | | | From | Ian Rogers <> | Date | Wed, 23 Nov 2022 15:33:55 -0800 | Subject | Re: [PATCH linux-next] perf stat: remove redundant variable in arch_get_topdown_pmu_name |
| |
On Wed, Nov 23, 2022 at 1:01 AM <zhang.songyi@zte.com.cn> wrote: > > From: zhang songyi <zhang.songyi@zte.com.cn> > > Return value from arch_get_topdown_pmu_name directly instead of taking > this in another redundant variable. > > Signed-off-by: zhang songyi <zhang.songyi@zte.com.cn>
Acked-by: Ian Rogers <irogers@google.com>
Thanks, Ian
> --- > tools/perf/arch/x86/util/topdown.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/tools/perf/arch/x86/util/topdown.c b/tools/perf/arch/x86/util/topdown.c > index 54810f9acd6f..5a5cdd6efe4d 100644 > --- a/tools/perf/arch/x86/util/topdown.c > +++ b/tools/perf/arch/x86/util/topdown.c > @@ -84,8 +84,6 @@ bool arch_topdown_sample_read(struct evsel *leader) > > const char *arch_get_topdown_pmu_name(struct evlist *evlist, bool warn) > { > - const char *pmu_name; > - > if (!perf_pmu__has_hybrid()) > return "cpu"; > > @@ -95,9 +93,7 @@ const char *arch_get_topdown_pmu_name(struct evlist *evlist, bool warn) > evlist->hybrid_pmu_name = perf_pmu__hybrid_type_to_pmu("core"); > } > > - pmu_name = evlist->hybrid_pmu_name; > - > - return pmu_name; > + return evlist->hybrid_pmu_name; > } > > int topdown_parse_events(struct evlist *evlist) > -- > 2.15.2
| |