Messages in this thread | | | From | Ian Rogers <> | Date | Wed, 23 Nov 2022 15:24:06 -0800 | Subject | Re: [PATCH 07/15] perf stat: Pass const char *prefix to display routines |
| |
On Wed, Nov 23, 2022 at 10:02 AM Namhyung Kim <namhyung@kernel.org> wrote: > > This is a minor cleanup and preparation for the later change. > > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Ian Rogers <irogers@google.com>
Thanks, Ian
> --- > tools/perf/util/iostat.h | 2 +- > tools/perf/util/stat-display.c | 18 +++++++++--------- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/tools/perf/util/iostat.h b/tools/perf/util/iostat.h > index 23c1c46a331a..c22688f87cb2 100644 > --- a/tools/perf/util/iostat.h > +++ b/tools/perf/util/iostat.h > @@ -28,7 +28,7 @@ enum iostat_mode_t { > > extern enum iostat_mode_t iostat_mode; > > -typedef void (*iostat_print_counter_t)(struct perf_stat_config *, struct evsel *, char *); > +typedef void (*iostat_print_counter_t)(struct perf_stat_config *, struct evsel *, const char *); > > int iostat_prepare(struct evlist *evlist, struct perf_stat_config *config); > int iostat_parse(const struct option *opt, const char *str, > diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c > index b8432c0a0ec3..d2894a519d61 100644 > --- a/tools/perf/util/stat-display.c > +++ b/tools/perf/util/stat-display.c > @@ -675,7 +675,7 @@ static bool is_mixed_hw_group(struct evsel *counter) > > static void printout(struct perf_stat_config *config, struct aggr_cpu_id id, int nr, > struct evsel *counter, double uval, > - char *prefix, u64 run, u64 ena, double noise, > + const char *prefix, u64 run, u64 ena, double noise, > struct runtime_stat *st, int map_idx) > { > struct perf_stat_output_ctx out; > @@ -804,7 +804,7 @@ static void uniquify_counter(struct perf_stat_config *config, struct evsel *coun > > static void print_counter_aggrdata(struct perf_stat_config *config, > struct evsel *counter, int s, > - char *prefix) > + const char *prefix) > { > FILE *output = config->output; > u64 ena, run, val; > @@ -843,7 +843,7 @@ static void print_counter_aggrdata(struct perf_stat_config *config, > > static void print_metric_begin(struct perf_stat_config *config, > struct evlist *evlist, > - char *prefix, int aggr_idx, > + const char *prefix, int aggr_idx, > struct cgroup *cgrp) > { > struct perf_stat_aggr *aggr; > @@ -874,7 +874,7 @@ static void print_metric_end(struct perf_stat_config *config) > > static void print_aggr(struct perf_stat_config *config, > struct evlist *evlist, > - char *prefix) > + const char *prefix) > { > struct evsel *counter; > int s; > @@ -901,7 +901,7 @@ static void print_aggr(struct perf_stat_config *config, > > static void print_aggr_cgroup(struct perf_stat_config *config, > struct evlist *evlist, > - char *prefix) > + const char *prefix) > { > struct evsel *counter, *evsel; > struct cgroup *cgrp = NULL; > @@ -934,7 +934,7 @@ static void print_aggr_cgroup(struct perf_stat_config *config, > } > > static void print_counter(struct perf_stat_config *config, > - struct evsel *counter, char *prefix) > + struct evsel *counter, const char *prefix) > { > int s; > > @@ -952,7 +952,7 @@ static void print_counter(struct perf_stat_config *config, > > static void print_no_aggr_metric(struct perf_stat_config *config, > struct evlist *evlist, > - char *prefix) > + const char *prefix) > { > int all_idx; > struct perf_cpu cpu; > @@ -1301,7 +1301,7 @@ static void print_footer(struct perf_stat_config *config) > } > > static void print_percore(struct perf_stat_config *config, > - struct evsel *counter, char *prefix) > + struct evsel *counter, const char *prefix) > { > bool metric_only = config->metric_only; > FILE *output = config->output; > @@ -1345,7 +1345,7 @@ static void print_percore(struct perf_stat_config *config, > } > > static void print_cgroup_counter(struct perf_stat_config *config, struct evlist *evlist, > - char *prefix) > + const char *prefix) > { > struct cgroup *cgrp = NULL; > struct evsel *counter; > -- > 2.38.1.584.g0f3c55d4c2-goog >
| |