lkml.org 
[lkml]   [2022]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 02/15] perf stat: Move summary prefix printing logic in CSV output
On Wed, Nov 23, 2022 at 10:02 AM Namhyung Kim <namhyung@kernel.org> wrote:
>
> It matches to the prefix (interval timestamp), so better to have them together.
> No functional change intended.
>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
> tools/perf/util/stat-display.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index 46e90f0bb423..d86f2f8e020d 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -713,11 +713,6 @@ static void printout(struct perf_stat_config *config, struct aggr_cpu_id id, int
> nl = config->metric_only ? new_line_metric : new_line_std;
> }
>
> - if (!config->no_csv_summary && config->csv_output &&
> - config->summary && !config->interval && !config->metric_only) {
> - fprintf(config->output, "%16s%s", "summary", config->csv_sep);
> - }
> -
> if (run == 0 || ena == 0 || counter->counts->scaled == -1) {
> if (config->metric_only) {
> pm(config, &os, NULL, "", "", 0);
> @@ -828,8 +823,13 @@ static void print_counter_aggrdata(struct perf_stat_config *config,
> ena = aggr->counts.ena;
> run = aggr->counts.run;
>
> - if (prefix && !metric_only)
> - fprintf(output, "%s", prefix);
> + if (!metric_only) {
> + if (prefix)
> + fprintf(output, "%s", prefix);
> + else if (config->summary && config->csv_output &&
> + !config->no_csv_summary && !config->interval)
> + fprintf(output, "%16s%s", "summary", config->csv_sep);
> + }
>
> uval = val * counter->scale;
>
> --
> 2.38.1.584.g0f3c55d4c2-goog
>

\
 
 \ /
  Last update: 2022-11-24 00:22    [W:0.058 / U:1.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site