lkml.org 
[lkml]   [2022]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/6] Revert "dt-bindings: marvell,prestera: Add description for device-tree bindings"

    On Thu, 17 Nov 2022 22:55:52 +0100, Miquel Raynal wrote:
    > This reverts commit 40acc05271abc2852c32622edbebd75698736b9b.
    >
    > marvell,prestera.txt is an old file describing the old Alleycat3
    > standalone switches. The commit mentioned above actually hacked these
    > bindings to add support for a device tree property for a more modern
    > version of the IP connected over PCI, using only the generic compatible
    > in order to retrieve the device node from the prestera driver to read
    > one static property.
    >
    > The problematic property discussed here is "base-mac-provider". The
    > original intent was to point to a nvmem device which could produce the
    > relevant nvmem-cell. This property has never been acked by DT
    > maintainers and fails all the layering that has been brought with the nvmem
    > bindings by pointing at a nvmem producer, bypassing the existing nvmem
    > bindings, rather than a nvmem cell directly. Furthermore, the property
    > cannot even be used upstream because it expected the ONIE tlv driver to
    > produce a specific cell, driver which used nacked bindings and thus was
    > never merged, replaced by a more integrated concept: the nvmem-layout.
    >
    > So let's forget about this temporary addition, safely avoiding the need
    > for any backward compatibility handling. A new (yaml) binding file will
    > be brought with the prestera bindings, and there we will actually
    > include a description of the modern IP over PCI, including the right way
    > to point to a nvmem cell.
    >
    > Cc: Vadym Kochan <vadym.kochan@plvision.eu>
    > Cc: Taras Chornyi <tchornyi@marvell.com>
    > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
    > ---
    > .../bindings/net/marvell,prestera.txt | 34 -------------------
    > 1 file changed, 34 deletions(-)
    >

    Acked-by: Rob Herring <robh@kernel.org>

    \
     
     \ /
      Last update: 2022-11-23 23:03    [W:3.910 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site